Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ToTable operation to output data as ASCII or HTML tables. #294

Merged
merged 2 commits into from
May 4, 2018

Conversation

JustAnotherMark
Copy link
Contributor

This attempts to resolve #275

This will be my first contribution to CyberChef so open to any feedback or corrections if I've missed anything.

Also, after starting work on this I noticed the ESM rewrite that's currently underway. Obviously, I'm happy for this PR to be ignored until that's complete and I can update it to work with the new system as required.

Screenshot of the new operation:
totable-operation-demo

@n1474335
Copy link
Member

This looks great! Have you signed our Contributor Licence Agreement so that I can merge this?

@JustAnotherMark
Copy link
Contributor Author

@n1474335 Yeah, I sent the email agreeing to it on Monday. Should I have got any confirmation or anything?

@n1474335
Copy link
Member

No, it just takes a while for it to get through to me. Thanks very much for the contribution, we'll definitely merge it soon.

@n1474335 n1474335 merged commit 411bba5 into gchq:master May 4, 2018
@n1474335
Copy link
Member

n1474335 commented May 4, 2018

Awesome work @JustAnotherMark, thanks very much for this. I've made a few changes so that it's easier to support CSV, PSV and TSV file types. I've also switched to using the Utils.parseCSV() function as this handles strings with embedded delimiters a bit better. See this example.

Thanks for the contribution, this will be particularly useful and ticks another one off the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operation request: Display CSV
2 participants